Author: Victor Kareh <vkareh@redhat.com>
weather: Fix inverted imperial forecast temperatures When converting to imperial units, the min and max temperatures were incorrectly inverted, causing confusion in the display. Fixes https://github.com/InfiniTimeOrg/InfiniTime/issues/2183
src/displayapp/screens/Weather.cpp | 6 +++---
diff --git a/src/displayapp/screens/Weather.cpp b/src/displayapp/screens/Weather.cpp index d3ee78efee728db2eb7e7230374aaf4c3b64e3ad..25464c70cf88da2455a0eec14d86cdb073789b0e 100644 --- a/src/displayapp/screens/Weather.cpp +++ b/src/displayapp/screens/Weather.cpp @@ -154,11 +154,11 @@ if (optCurrentForecast) { std::tm localTime = *std::localtime(reinterpret_cast<const time_t*>(&optCurrentForecast->timestamp)); for (int i = 0; i < optCurrentForecast->nbDays; i++) { - int16_t minTemp = optCurrentForecast->days[i]->minTemperature.Celsius(); int16_t maxTemp = optCurrentForecast->days[i]->maxTemperature.Celsius(); + int16_t minTemp = optCurrentForecast->days[i]->minTemperature.Celsius(); if (settingsController.GetWeatherFormat() == Controllers::Settings::WeatherFormat::Imperial) { - minTemp = optCurrentForecast->days[i]->maxTemperature.Fahrenheit(); - maxTemp = optCurrentForecast->days[i]->minTemperature.Fahrenheit(); + maxTemp = optCurrentForecast->days[i]->maxTemperature.Fahrenheit(); + minTemp = optCurrentForecast->days[i]->minTemperature.Fahrenheit(); } lv_table_set_cell_type(forecast, 2, i, TemperatureStyle(optCurrentForecast->days[i]->maxTemperature)); lv_table_set_cell_type(forecast, 3, i, TemperatureStyle(optCurrentForecast->days[i]->minTemperature));