Author: Adam Pioterek <adam.pioterek@protonmail.ch>
remove some todos
%!v(PANIC=String method: strings: negative Repeat count)
diff --git a/app/src/main/java/ml/adamsprogs/bimba/ProviderProxy.kt b/app/src/main/java/ml/adamsprogs/bimba/ProviderProxy.kt index 59fb99a4f9c56b6927f3996146904d74b070883e..a782388d35c50c2fa78fb11c4647f24924c1d637 100644 --- a/app/src/main/java/ml/adamsprogs/bimba/ProviderProxy.kt +++ b/app/src/main/java/ml/adamsprogs/bimba/ProviderProxy.kt @@ -15,7 +15,6 @@ import ml.adamsprogs.bimba.models.suggestions.StopSuggestion import java.util.* import kotlin.collections.HashMap -//todo make singleton class ProviderProxy(context: Context? = null) { private val vmClient = VmClient.getVmClient() private var timetable: Timetable = Timetable.getTimetable(context) diff --git a/app/src/main/java/ml/adamsprogs/bimba/models/adapters/SuggestionsAdapter.kt b/app/src/main/java/ml/adamsprogs/bimba/models/adapters/SuggestionsAdapter.kt index a9fb15deb860b64e735f75e4bf3d3f67740e98fb..67f5dfd4134c978aa78c284f9c0d22d7975294d7 100644 --- a/app/src/main/java/ml/adamsprogs/bimba/models/adapters/SuggestionsAdapter.kt +++ b/app/src/main/java/ml/adamsprogs/bimba/models/adapters/SuggestionsAdapter.kt @@ -18,8 +18,6 @@ import ml.adamsprogs.bimba.models.suggestions.LineSuggestion import ml.adamsprogs.bimba.models.suggestions.StopSuggestion import com.mancj.materialsearchbar.adapter.SuggestionsAdapter as SearchBarSuggestionsAdapter -// todo on click ripple - class SuggestionsAdapter(inflater: LayoutInflater, private val onSuggestionClickListener: OnSuggestionClickListener, private val context: Context) : SearchBarSuggestionsAdapter<GtfsSuggestion, SuggestionsAdapter.ViewHolder>(inflater) { override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolder { diff --git a/app/src/main/res/layout/activity_dash.xml b/app/src/main/res/layout/activity_dash.xml index 609808f63d7b17a1da73c23422511a04ee87d717..d0823ba430d5269b6015012226f003dea7223b0c 100644 --- a/app/src/main/res/layout/activity_dash.xml +++ b/app/src/main/res/layout/activity_dash.xml @@ -41,7 +41,6 @@ app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@+id/search_view" /> - <!-- todo maxCount? --> <com.mancj.materialsearchbar.MaterialSearchBar android:id="@+id/search_view" style="@style/SearchBarTheme" diff --git a/todo b/todo index 062fa624ca055386d0690ed1f48b82ae41f74856..c3e273d3fa766894a60097822e9ee72a7f70048c 100644 --- a/todo +++ b/todo @@ -9,5 +9,6 @@ - departures empty - search result retry - shed retry - departures retry -- ripples -- search results flickering +- ripples android:background="?android:attr/selectableItemBackground" +x search results flickering +- favourite cache